Prevent writing of file if request was not successful #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annehaley
approved these changes
Oct 1, 2024
You're right, it more just fixes the issue for local dev, since you can just re-run it until it succeeds. I'll remove the link to that issue so this PR won't close it, and reword the issue a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the request to retrieve certain files from DKC often fails with a
502 Bad Gateway, but the file is still written to anyway. Since the file is only written to the first time, this means that if this bad request happens when first runningpopulate, the bad file will remain there until the file item is deleted.